Investments are not intended to make money for the character or the family. It doesn't work that way. They may make money for the realm. But most often, they are used to either quickly repair production in a region, or to funnel gold to a realm. (i..e you character on AT sends money to the family, and your character on Dwilight does an investment, thus "moving" gold from AT to Dwilight.)