BattleMaster Community

BattleMaster => Development => Topic started by: Eithad on February 01, 2012, 09:40:04 PM

Title: Tax collection Bug
Post by: Eithad on February 01, 2012, 09:40:04 PM
The effect seems to be most pronounce in regions without knights, cities appear to be not affected as far as I can tell. Numbers seem to be twice as high as they should be, or the estates page isn't updated with new numbers.

(http://gyazo.com/14c12605fddfda846a219ccd61eb1363.png?1328127599)
From the tax report

(http://gyazo.com/6bdb1674725bd24c3cce1c3080809caf.png?1328127728)
From the estates estimate page
Title: Re: Tax collection Bug
Post by: fodder on February 01, 2012, 10:53:47 PM
are you sure tax period was 7 days? XD
Title: Re: Tax collection Bug
Post by: Tom on February 02, 2012, 11:14:13 AM
That sure looks like a bug. The estimate should be pretty good, though never precise because it doesn't take stuff like trade balance into account. But in this specific case, the other factors are all minor and still the estimate is off.

I will have to check this out.

Title: Re: Tax collection Bug
Post by: JPierreD on February 04, 2012, 12:02:09 AM
Seems to have happened in Barca and Luria Nova as well. I usually get ~120 gold as a knight, got ~500 this taxes.
Title: Re: Tax collection Bug
Post by: De-Legro on February 04, 2012, 12:06:10 AM
Seems to have happened in Barca and Luria Nova as well. I usually get ~120 gold as a knight, got ~500 this taxes.

Oh my, can you imagine how the current war is going is escalate given these new incomes?
Title: Re: Tax collection Bug
Post by: Geronus on February 04, 2012, 07:26:56 AM
Yep just happened to me too. Nice windfall actually. I feel like a Duke.

Region Tax Report   (56 minutes ago)
message to the lord and knights of Gelene Outskirts
The following taxes were collected in Gelene Outskirts. The tax rate for this collection was 12 % and the lords share was 20 %.

Regional income and expensesPeasants Taxes   1820 gold
Taxes from Guildhouses   + 1 gold
Buildings Upkeep   - 15 gold
Militia Payment   - 164 gold
Collectable Tax Gold   1642 gold
Estate of   Size   Peasants   Tax Collected   Knight Share   Lord Share
(vacant)   30 %   5790   246 gold      246 gold
(vacant)   20 %   3860   164 gold      164 gold
Lysander   30 %   5790   492 gold      492 gold
(vacant)   20 %   3860   164 gold      164 gold
Region Totals         1066 gold   0 gold   1066 gold

Lord and Duke SharesLord Share   1066 gold
Dukes Share   - 54 gold
Lords Tax Income   1012 gold
Title: Re: Tax collection Bug
Post by: fodder on February 04, 2012, 07:48:26 AM
um... remind me how tax numbers are calculated....  (this is for nebel, dwi, the knight ivan)

this is the pop rebalance text for nebel...
(11 days, 22 hours ago)
The tax rate for this collection was 9 %
Gold Income   581   827   + 43 %

previous tax (7 day period)
(8 days ago)
Peasants Taxes   480 gold

current tax (8 day period - something went wonky and 1 day was added... don't think the cycle went wrong again, just this tax.. eh.. i think)
(1 hour ago) The tax rate for this collection was 9 %
Peasants Taxes   1114 gold

granted.. 1/2 the tax in the previous tax was under old system.. but still?

-------
incidentally... estimate of a 40% estate = 155 gold (before lord share and all)

---
can't tell if the region i'm running in bt is affected or not... seeing as i ran an investment there.. but tax didn't double for certain between the recent and the previous taxes. despite similar gold increase in the rebalance text
Title: Re: Tax collection Bug
Post by: egamma on February 04, 2012, 12:05:58 PM
6133--last d'hara tax 8 days ago
11521--today's tax

Not that I'm complaining!
Title: Re: Tax collection Bug
Post by: Tom on February 04, 2012, 02:23:41 PM
Well, we did change lots of things there.

What I'm interested in is if the tax estimates and the actual taxes agree with each other.

Title: Re: Tax collection Bug
Post by: fodder on February 04, 2012, 03:58:29 PM
for nebel, dwi, i don't think it does.
estimate <200 vs 8 days taxes of 400ish

for avengmil, bt... it might.
estimate (after investment finished) ~250 vs 8 days taxes ~350 <--- but that's after an investment of ~300 split between 3 nobles.
Title: Re: Tax collection Bug
Post by: egamma on February 04, 2012, 05:02:30 PM
The TaxOverview page says that some regions--like cities--are close, while townslands are way off estimate.

(http://i.imgur.com/pZSMG.png)

(http://i.imgur.com/vMkiV.png)

I trust this won't be abused...
Title: Re: Tax collection Bug
Post by: fodder on February 04, 2012, 05:42:51 PM
as for the overview page (which i guess if that lower pic?)... not sure you can read too much off that, because i don't think the "gold" number listed there is a tax estimate... it simply lists the number from regiondetails... (as far as i can see)... forgot how you calculate tax from that.


----
speaking of abuse... you know.. you can make a bugtracker note private... but not uploaded files?
Title: Re: Tax collection Bug
Post by: egamma on February 04, 2012, 07:14:44 PM
as for the overview page (which i guess if that lower pic?)... not sure you can read too much off that, because i don't think the "gold" number listed there is a tax estimate... it simply lists the number from regiondetails... (as far as i can see)... forgot how you calculate tax from that.


----
speaking of abuse... you know.. you can make a bugtracker note private... but not uploaded files?

Or send it in a PM to Tom. I know, I just figure that nobody is gunning for us at the moment, and besides, similar information can be gathered from the statistics.
Title: Re: Tax collection Bug
Post by: Tom on February 04, 2012, 07:58:24 PM
as for the overview page (which i guess if that lower pic?)... not sure you can read too much off that, because i don't think the "gold" number listed there is a tax estimate... it simply lists the number from regiondetails... (as far as i can see)... forgot how you calculate tax from that.

Correct. I would need the page where you see the tax estimates. I think it's on the estates page of the lord.
Title: Re: Tax collection Bug
Post by: fodder on February 04, 2012, 10:01:05 PM
bear in mind that an investment was made somewhere between the last 2 taxes.. and halfway between 2and 3 taxes ago pop was rebalanced. (and i've been fiddling with rates between 16 and 17)

this is for avengmil, bt

rebalance text 12 days ago..
The region population rebalance has been applied to this island. The changes for your region are as follows:
   old   new   change
Population   8900   10200   + 15 %
Food Production   173   239   + 38 %
Gold Income   565   817   + 45 %
Title: Re: Tax collection Bug
Post by: Tom on February 04, 2012, 11:53:17 PM
I've checked the database and everything looks to be alright.

I think we should wait a couple more days until the tax collections are 100% free of any artifacts from the change.

Title: Re: Tax collection Bug
Post by: fodder on February 10, 2012, 07:53:49 AM
just to add some data points... 7day vanilla tax in avengmil, bt
estimate a bit on the low side.
Title: Re: Tax collection Bug
Post by: Tom on February 10, 2012, 10:00:38 AM
That is utterly strange. I've tripple-checked the code, and tax collection and tax estimates use the exact same formula. I don't see how they could differ, except by production within the region changing dramatically (as the tax estimate always uses todays production value).

Title: Re: Tax collection Bug
Post by: egamma on February 10, 2012, 02:12:02 PM
That is utterly strange. I've tripple-checked the code, and tax collection and tax estimates use the exact same formula. I don't see how they could differ, except by production within the region changing dramatically (as the tax estimate always uses todays production value).

...was the tax run on a 7 day cycle? I imagine the estimates would be way off for a 4-day tax run.
Title: Re: Tax collection Bug
Post by: fodder on February 10, 2012, 04:55:40 PM
production is 100% atm.. (it says "production remains unchanged" during the whole of the tax period) estimate is atm exactly the same as the one just after the last tax 7 days ago

no investment, though there were a couple of monster or undead battle with militia in the last 2 turn or so. doubt many troops were lost as they were ranged and behind walls.. winning both times.

does the estimate include militia/building upkeep? bizarre if it doesn't and is still way lower..

Region Tax Report   (7 days, 10 hours ago)
Region Tax Report   (10 hours, 39 minutes ago)

---
assuming tax is calculated as (because i don't have it written down XD):
region's gold number (817) x tax rate (17%) x number of days (7)
then the actual tax collected (973) is about right (cf: calculated 972.23)

so... question is then... why is the estimate iffy? XD
Title: Re: Tax collection Bug
Post by: Eithad on February 10, 2012, 10:02:58 PM
Because the estimate accounts for estate efficiency and the gold collected does not.
Title: Re: Tax collection Bug
Post by: Bael on February 10, 2012, 10:24:03 PM
A couple of regions in Barca recently produced a really low amount of gold, for no reason that I can see.

Thysan:   15 gold   
http://www.battlemaster.org/testing/RegionDetails.php?ID=95
One 50% estate, 50% vacant.
Population:       2628/3300
Estimated Region Gold
 at full population :       233 gold
Tax Rate: 13%
Production: Busy


Twainwood:   20 gold   
http://www.battlemaster.org/testing/RegionDetails.php?ID=92
Estate Coverage: Two 50% estates
Population: 2335/5900
Estimated Region Gold
at full population :   321 gold
Tax rate: Unknown (investigating)
Production: Slow

Any ideas?
Title: Re: Tax collection Bug
Post by: Eithad on February 10, 2012, 10:36:12 PM
A couple of regions in Barca recently produced a really low amount of gold, for no reason that I can see.

Thysan:   15 gold   
http://www.battlemaster.org/testing/RegionDetails.php?ID=95
One 50% estate, 50% vacant.
Population:       2628/3300
Estimated Region Gold
 at full population :       233 gold
Tax Rate: 13%
Production: Busy


Twainwood:   20 gold   
http://www.battlemaster.org/testing/RegionDetails.php?ID=92
Estate Coverage: Two 50% estates
Population: 2335/5900
Estimated Region Gold
at full population :   321 gold
Tax rate: Unknown (investigating)
Production: Slow

Any ideas?

Need more information and the links don't work. So the regions tax collection is 15 and 20 gold over a 7 day tax period? The problems I see are population is low, production is slow, estates are probably too big to be at full efficiency. Need to see the actual tax report to see how much gold is collected and where its going.
Title: Re: Tax collection Bug
Post by: fodder on February 10, 2012, 11:12:02 PM
huh? i thought you were saying actual tax collection is basically 100% efficiency for estates (aside from the vacant/wildlands) as opposed to the correct lower efficiency shown in estimates?

which actually sounds like you are onto something... at least regarding avengmil...

.. that said... different islands... d'hara had a 4 days tax... maybe i should post that too... (as soon as my trader with 10 men who expected to be fighting monsters alongside others gets out of prison)
Title: Re: Tax collection Bug
Post by: Tom on February 11, 2012, 04:53:58 AM
Because the estimate accounts for estate efficiency and the gold collected does not.

That's a really good catch, you might be right. I'll look at that when I'm not tired.
Title: Re: Tax collection Bug
Post by: fodder on February 17, 2012, 07:19:43 AM
i guess you found the problem? seems to be closer now..  just about all regions dropped in income too..

though production for avengmil did drop about 5% in the last few days.. and it did lose 8 gold to religious riots XD

the new estimate is from post tax @95% production
Title: Re: Tax collection Bug
Post by: Tom on February 17, 2012, 12:09:55 PM
Looks like it's fixed. That the estimate isn't spot-on is to be expected, as it doesn't take daily fluctuations into account.
Title: Re: Tax collection Bug
Post by: fodder on February 24, 2012, 08:15:18 AM
taxes collected for just about every region in riombara has gone up a bit this week (aside from fwuvoghor which has just lost the lord to emigration... and the regions with investment which has gone up a fair bit).

production for avengmil seems to have dropped a couple of % (now 93) some time during the 7 days (maybe when daimon son was captured? doesn't really say)... morale lower. no battles between the taxes. so estimates are low by ~30 a knight/lord when you compare with the previous estimate in above post.

is that still within the margin of error (for the estimate that is) or has it gone beyond?
(below is tax report and estimate after tax @93%)

-----
for nebel, d'hara
last 2 full taxes (3 days ago, 10 days ago) basically identical.. ~183-184
estimate = 174 (that's after the lord's cut...) so that's quite close.
Title: Re: Tax collection Bug
Post by: Tom on February 24, 2012, 10:48:59 AM
We still have a known bug open that tax collection does not actually apply efficiency. So with that in mind, things look correct otherwise.