BattleMaster Community

BattleMaster => Development => Topic started by: Tom on July 30, 2012, 08:10:16 PM

Title: New Treaty System
Post by: Tom on July 30, 2012, 08:10:16 PM
I have just pushed changes live that give all islands access to our brand new "new-new" treaty system.

You can find the details on the wiki (http://wiki.battlemaster.org/wiki/Enhanced_Diplomacy).

Basically, this is much like the "new treaty system" that had been broken around for a long while, except the game mechanics. Treaties are just texts that you sign, with a bit of mechanics for the signing process behind it. Making them free-form gives you, well total freedom in making up any treaty you want.

Existing treaties have been kept, so you should definitely check your treaty status and update your signatures on them. Right now, there is no cleanup of treaties, but soon treaties where all partners have withdrawn will be deleted.



Many thanks to Tim for his efforts, even though a large amount of the game-mechanics code for the new treaty system has ultimately been thrown out, the core of the system, including most of the database structure, is very much his work.

Title: Re: New Treaty System
Post by: Tom on July 30, 2012, 08:13:15 PM
Since the system is really new, and I hacked most of it up in the past three days, it is likely that there will be bugs. If so, please report them on the bugtracker and they will be fixed.

Title: Re: New Treaty System
Post by: Perth on July 30, 2012, 11:03:44 PM
I am really glad to hear this. I think, ultimately, it will add a lot to the game.
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 07:36:35 AM
Quote from: Perth on July 30, 2012, 11:03:44 PM
I am really glad to hear this. I think, ultimately, it will add a lot to the game.

I hope so. Looking for feedback now - it's pretty much finished.
Title: Re: New Treaty System
Post by: fodder on July 31, 2012, 07:38:16 AM
so the old system remains the basis on top of which people based their stuff on?

no option to share facilities without full alliance (or whatever it is), etc?
Title: Re: New Treaty System
Post by: De-Legro on July 31, 2012, 07:40:59 AM
Quote from: fodder on July 31, 2012, 07:38:16 AM
so the old system remains the basis on top of which people based their stuff on?

no option to share facilities without full alliance (or whatever it is), etc?

Yup. The new system is RP only with no supporting game mechanics.
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 07:59:36 AM
Quote from: fodder on July 31, 2012, 07:38:16 AM
so the old system remains the basis on top of which people based their stuff on?

no option to share facilities without full alliance (or whatever it is), etc?

Correct.

We are, however, considering adding one or two more settings to the old diplomacy system to allow for things like that.
Title: Re: New Treaty System
Post by: Draco Tanos on July 31, 2012, 09:42:13 AM
Tom, any chance you can add who wrote and who signed the treaties?
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 10:33:31 AM
Theoretically yes, but I have left it out on purpose. Everything in treaties is happening "in the name of the realm".

To keep a full record, it would be necessary to keep track of every change, too.

Title: Re: New Treaty System
Post by: Perth on July 31, 2012, 05:17:34 PM
I'm the Ruler of Eston, but it tells me I am not allowed to "Edit" any treaties as you instructed us to do to in order to save any we wish to keep over the next couple days. It tells me only Diplomats can do it. Is this intended? I don't think Eston has any diplomats....
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 07:06:49 PM
Quote from: Perth on July 31, 2012, 05:17:34 PM
I'm the Ruler of Eston, but it tells me I am not allowed to "Edit" any treaties as you instructed us to do to in order to save any we wish to keep over the next couple days. It tells me only Diplomats can do it. Is this intended? I don't think Eston has any diplomats....

what exact error text on what exact page?

it should alllow you to edit.
Title: Re: New Treaty System
Post by: egamma on July 31, 2012, 07:18:41 PM
Quote from: Tom on July 31, 2012, 07:06:49 PM
what exact error text on what exact page?

it should alllow you to edit.

"Only diplomats have the required legal, political and trickery knowledge to draft treaties."

I was able to sign several treaties that appeared to be unsigned--will that keep them from being scrapped?
Title: Re: New Treaty System
Post by: Perth on July 31, 2012, 07:58:25 PM
Quote from: Tom on July 31, 2012, 07:06:49 PM
what exact error text on what exact page?

it should alllow you to edit.

I go Politics > View Treaties > Edit > "Only diplomats have the required legal, political and trickery knowledge to draft treaties."
Title: Re: New Treaty System
Post by: fodder on July 31, 2012, 08:32:57 PM
i was going to say... what if you use info->diplomatic treaties->edit... but it looks like they should go to the same place. XD
Title: Re: New Treaty System
Post by: Foundation on July 31, 2012, 08:42:58 PM
Currently only those with the Ambassador or Diplomat subclasses could edit.  Is it desired that any Ruler automatically get to bypass that requirement?
Title: Re: New Treaty System
Post by: Perth on July 31, 2012, 08:48:58 PM
Quote from: fodder on July 31, 2012, 08:32:57 PM
i was going to say... what if you use info->diplomatic treaties->edit... but it looks like they should go to the same place. XD

I thought and tried the same thing.
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 11:01:18 PM
Quote from: Perth on July 31, 2012, 07:58:25 PM
I go Politics > View Treaties > Edit > "Only diplomats have the required legal, political and trickery knowledge to draft treaties."

yes. as ruler, you can sign, but not edit.

You should get a diplomat into your realm or ask if someone is willing to do it. You really want one.
Title: Re: New Treaty System
Post by: Tom on July 31, 2012, 11:01:43 PM
Quote from: Foundation on July 31, 2012, 08:42:58 PM
Currently only those with the Ambassador or Diplomat subclasses could edit.  Is it desired that any Ruler automatically get to bypass that requirement?

No. If he wants to, he can change subclass.
Title: Re: New Treaty System
Post by: fodder on July 31, 2012, 11:43:58 PM
do you need different people to do the signing and proposing/editing?
Title: Re: New Treaty System
Post by: Perth on August 01, 2012, 12:18:52 AM
Quote from: Tom on July 31, 2012, 11:01:18 PM
You should get a diplomat into your realm or ask if someone is willing to do it. You really want one.

There were a few in the past, but as the new treaty system was declared defunct, I don't currently have any. But I'll work on finding some.
Title: Re: New Treaty System
Post by: Foundation on August 01, 2012, 12:21:56 AM
Ah, okay.  So it was intended that rulers cannot edit without subclasses.
Title: Re: New Treaty System
Post by: Tom on August 01, 2012, 07:41:10 AM
Quote from: fodder on July 31, 2012, 11:43:58 PM
do you need different people to do the signing and proposing/editing?


At this time, no. You do need the ruler or an ambassador to sign, however. So if you are just a diplomat, you do.
Title: Re: New Treaty System
Post by: Antonine on August 01, 2012, 09:32:38 PM
One of my chars is an ambassador but there's a crash when she tries to edit an existing treaty that's already been signed between her realm and another realm.

The crash message is this:

Fatal error: Uncaught exception 'BadMethodCallException' with message 'Data item "title" does not exist' in /var/battlemaster/include/Doctrine/BattleMaster/GameObject.php:42 Stack trace: #0 /var/battlemaster/include/Doctrine/BattleMaster/GameObject.php(15): BattleMaster\GameObject->_set('title', 'Surrender Terms...') #1 /var/battlemaster/live/stable/DraftTreaty.php(33): BattleMaster\GameObject->__call('setTitle', Array) #2 /var/battlemaster/live/stable/DraftTreaty.php(33): BattleMaster\Treaty->setTitle('Surrender Terms...') #3 {main} thrown in /var/battlemaster/include/Doctrine/BattleMaster/GameObject.php on line 42
Title: Re: New Treaty System
Post by: Tom on August 01, 2012, 09:38:38 PM
fixing those bugs as we speak
Title: Re: New Treaty System
Post by: Foundation on August 01, 2012, 10:13:45 PM
That particular one was already fixed, please check the bugtracker for fixed revision. :)
Title: Re: New Treaty System
Post by: Tom on August 02, 2012, 06:26:44 AM
damn, another 30 seconds wasted. :-)