BattleMaster Community

BattleMaster => Development => Topic started by: Indirik on August 05, 2012, 07:45:34 PM

Title: New RegionDetails format
Post by: Indirik on August 05, 2012, 07:45:34 PM
The new format for the tabbed region details page is nice. However, for scout reports it no longer defaults to the Military tab. Can this be changed back?
Title: Re: New RegionDetails format
Post by: Cren on August 05, 2012, 08:39:31 PM
On IE 7, I can't change tabs. On other browsers, its Ok. Really IE is crap.
Title: Re: New RegionDetails format
Post by: Tom on August 05, 2012, 11:37:44 PM
I couldn't care less about IE, and anything prior to 9 is something where I consider the browser the bug.

Defaulting to the military tab is not entirely trivial. Doable, but not in 2 minutes.
Title: Re: New RegionDetails format
Post by: Indirik on August 06, 2012, 12:39:14 AM
View Source on a RegionDetails.php page turns up this bit of javascript at the end of the page, just before the closing body tag:

<script type="text/javascript">
$(document).ready(function() {
$("#tabs").tabs();
$("#tabs").tabs('select', '#military');
});
</script>


Maybe something that could be copied over to ShowScribeNote.php?
Title: Re: New RegionDetails format
Post by: Perth on August 06, 2012, 02:19:51 AM
Agreed, it looks very nice!
Title: Re: New RegionDetails format
Post by: Lanyon on August 06, 2012, 03:05:33 AM
It's so pretty!!!!
Title: Re: New RegionDetails format
Post by: Tom on August 06, 2012, 08:44:25 AM
Quote from: Indirik on August 06, 2012, 12:39:14 AM
View Source on a RegionDetails.php page turns up this bit of javascript at the end of the page, just before the closing body tag:

Yes, I know, I put it there.

The problem is that this is the output. The actual PHP is this:


    $("#tabs").tabs('select', '#<?=$FullInfo?'military':'desc'?>');


And the $FullInfo variable isn't available in the scribe notes. That's why I said it's not trivial.
Title: Re: New RegionDetails format
Post by: Azerax on August 06, 2012, 09:32:25 PM
Quote from: Lanyon on August 06, 2012, 03:05:33 AM
It's so pretty!!!!

Yup, very visually appealing, nice work!
Title: Re: New RegionDetails format
Post by: Blue Star on August 06, 2012, 11:52:51 PM
It's a lot nicer
Title: Re: New RegionDetails format
Post by: Cren on August 08, 2012, 05:32:10 PM
Another nail on the coffin of IE. :-P