BattleMaster Community

BattleMaster => Development => Topic started by: feyeleanor on August 06, 2013, 03:14:29 PM

Title: Coder qualifications
Post by: feyeleanor on August 06, 2013, 03:14:29 PM
Everything you're talking about doing requires more people's time. Developers' time.

Right now, you know how many developers there are actively doing stuff?

Me.

And I have a real job, and a wife, and at least the rudiments of a social life.

Yes, I would love to be able to say, "Here! Here is the brand-new mobile BattleMaster site, guaranteed to be at least 5000% better than before! Here is a brand-new island to move the people from our X deleted islands to, to get everyone interested in exploring again! Here are the 30 most-needed new features and big changes to make the game in general more fun to play, so everyone playing is more likely to stay, new or not!"

But as much as I honestly enjoy working on BattleMaster development, and do devote a lot of spare time to it, for me to do all that stuff by myself, at the current rates, would take at least a year or two.

I've often considered signing up for the dev team but juggling family and work has always made getting involved seem impractical. However if things are really at the point where ongoing dev work is hanging by a thread then I'd be willing to pitch in and help if you don't mind a PHP newb poking around in the codebase.
Title: Re: Coder qualifications
Post by: egamma on August 06, 2013, 06:48:09 PM
I've often considered signing up for the dev team but juggling family and work has always made getting involved seem impractical. However if things are really at the point where ongoing dev work is hanging by a thread then I'd be willing to pitch in and help if you don't mind a PHP newb poking around in the codebase.

send an email to tom (@lemuria.org) with your experience. I think you need Doctrine experience to work on the main game code, but if you take a look at the bugtracker, there's probably something there you could fix. Bugs are piling up, Doctrine conversion is basically stalled.
Title: Re: Coder qualifications
Post by: Anaris on August 06, 2013, 07:22:47 PM
PHP and Doctrine experience are preferred.

However, though Tom may disagree with me (and, of course, he has the last word), I would personally say that all that should be required is solid programming skill, a willingness to learn (carrying with it a willingness to be, essentially, on probation for the first few months), and a good attitude about the whole thing.

When I started as a dev, I'd never touched a line of PHP. I learned it on the job, and I am fully confident that others could do the same, provided they have a good foundation.

It's not like we're oversupplied with PHP/Doctrine gurus volunteering, after all :P
Title: Re: Coder qualifications
Post by: Naidraug on August 06, 2013, 08:01:46 PM
PHP and Doctrine experience are preferred.

However, though Tom may disagree with me (and, of course, he has the last word), I would personally say that all that should be required is solid programming skill, a willingness to learn (carrying with it a willingness to be, essentially, on probation for the first few months), and a good attitude about the whole thing.

When I started as a dev, I'd never touched a line of PHP. I learned it on the job, and I am fully confident that others could do the same, provided they have a good foundation.

It's not like we're oversupplied with PHP/Doctrine gurus volunteering, after all :P

Hey if we are allowed to learn PHP/Doctrine on the job, I think I can sign up to help too. And wouldn't mind beeing on probation for a few months.

 I´ll send Tom an email about it.
Title: Re: Coder qualifications
Post by: Tom on August 06, 2013, 09:02:08 PM
PHP and Doctrine experience are preferred.

However, though Tom may disagree with me

I do. Past experience has shown that bringing new people up to speed takes a considerable amount of time and effort from the existing dev people. It is an investment. And Tim, you are the rare exception where the investment has paid back massively. You and I both remember quite a few cases where we invested the time and the volunteers just vanished on us. And, before anyone jumps up saying "I would never do that" - all of them said the same thing.
Title: Re: Coder qualifications
Post by: egamma on August 06, 2013, 10:34:03 PM
What if you just gave feyeleanor a few of the "manual/text" bug code snippets, let him work on them, and submit them back for review? Start with those, since they are presumably the easiest.
Title: Re: Coder qualifications
Post by: Watly on August 07, 2013, 12:37:06 AM
I am willing to help as well, but have very little experience with programming. I am not going to beg for training, but will try to learn it on my own.

What I can offer is a mathematical head and an eye for detail combined with an insane amount of free time, though I doubt that is necessary at this point.
Title: Re: Coder qualifications
Post by: Tom on August 07, 2013, 03:13:36 AM
What if you just gave feyeleanor a few of the "manual/text" bug code snippets, let him work on them, and submit them back for review? Start with those, since they are presumably the easiest.

It's not a question of how to do it. No matter how, you still need someone to explain things, review things, work with him, answer questions, bring him up to speed. And that's no matter who it is. The problem is that we don't have the resources for that, if it is not guaranteed that there will be return on investment. And it isn't, no one can guarantee that he won't give up or lose interest.

Back when we had 3 coders, that wasn't as much as an issue. And as enthusiastic as Tim is, I do try to make sure he's not burnt out.

Title: Re: Coder qualifications
Post by: Tom on August 07, 2013, 03:14:43 AM
However... maybe, just maybe... if we can get a small team, let's say 3 people, who are willing to support each other and learn on their own, we could tackle that newspaper system I talked about as a standalone project. It would give everyone enough experience with PHP and Doctrine to make the jump into the BM code a lot easier.

Title: Re: Coder qualifications
Post by: Anaris on August 07, 2013, 03:55:11 AM
However... maybe, just maybe... if we can get a small team, let's say 3 people, who are willing to support each other and learn on their own, we could tackle that newspaper system I talked about as a standalone project. It would give everyone enough experience with PHP and Doctrine to make the jump into the BM code a lot easier.

For the love of Cthulhu, Tom, if we had 3 people like that, I could use the crap out of them just fixing the damn bugs that have been accreting lately.

Seriously, I'm not going to get burned out helping a small team learn the ropes and easing them into bugfixing. Heck, even less so than a single person, most likely, because I can tell them all the same thing at once and get 3 times the return out of it.

What is more likely to burn me out is continuing to work alone on this forever, trying desperately to both move the game forward and tackle the rising tide of bugs by myself.

Bugfixing is so useful for getting new devs—even those new to PHP and Doctrine—up to speed. I can point them at general areas of code, describe the gist of how things are supposed to work, and review diffs without much trouble. True, for the first few bugs, I'd probably be spending as much effort guiding the newbies as I would fixing them myself. But that effort quickly starts to pay itself back as they are able to fix more bugs on their own.

The big key features, though, are "self-motivated" and "good at learning on the fly." And those are things that, so far as I can tell, there's absolutely no way to test for except to try it out and see.
Title: Re: Coder qualifications
Post by: Anaris on August 07, 2013, 03:58:07 AM
...and I really think you're way, way too hung up on the idea of writing a newspaper interface from scratch. I am 95% convinced that the Wikilog extension and a little bit of Wiki-fu will do everything we want on that front.
Title: Re: Coder qualifications
Post by: Swiftblade on August 07, 2013, 08:41:04 AM
If you are willing to take people with no coding experience and show them the ropes then I will put my hand up, as I have basic knowledge of PHP (done some bug fixing and making code fit) and have had quite a lot of experience with HTML and CSS. I have never worked with Doctrine, reading up on it now, and I have never made a full project out of PHP on my own, but I have altered and fixed other peoples code basically, and I know how databases work and what not. I also have computer technician and troubleshooting experience, experience running support services and I have run and configured quite a few forums/blogs/basic websites for people.

I have to use reference sheets quite a bit, because I don't often remember exact syntax right away, but after doing it for a while its usually in there for good. I would love to try out for this probation type deal, fix some bugs etc, and with some guidance I may be able to get up to scratch and start pulling my weight.

Let me know what I need to do to get in on this and I'll give it a shot.
Title: Re: Coder qualifications
Post by: Vita` on August 07, 2013, 08:44:24 AM
If I could sync my changes to the repository, the following bugs/small features would be fixed for the next update and I would probably feel a bit more motivated to fix a bunch more on my list.

Title: Re: Coder qualifications
Post by: Tom on August 07, 2013, 11:21:42 AM
...and I really think you're way, way too hung up on the idea of writing a newspaper interface from scratch. I am 95% convinced that the Wikilog extension and a little bit of Wiki-fu will do everything we want on that front.

It still requires people to learn the wiki syntax and fiddle around with templates that break your entire page if you forget one } anywhere. That is the problem. I'm sure that technically you can coerce MediaWiki into doing what we need, but it will never be beautiful nor easy to use.

BM really could use some parts that are 21st century. Visual appeal is what draws people in. The newspapers could be something really cool to make new players interested. If you implement something from scratch, you can do magic like this:
Try out these demos and then tell me you wouldn't take those any day over fiddling with {{Usr|Tom}}}}|author = {{Usr|Indirik}}}}{{TattleLeft|date = May  21, 2010|title = Server Status.



You and I are coders, Tim. We don't mind the wiki syntax, but you'll have to agree that with complex templating, it is sometimes a bit confusing even to us. Now imagine the 95% of players who are NOT coders.
I am trying to get the barrier-to-entry down, so more people can participate in newspapers, that's all. People desire the local forums, mostly because they are EASY places to exchange stuff. But they are OOC as hell. A newspaper could be made an in-game item. And yes, they would be propaganda rags. That would be the whole beauty: If your enemy publishes one, you can't reply (not a forum) - but you can start your own.






Title: Re: Coder qualifications
Post by: egamma on August 07, 2013, 02:44:06 PM
Well, so far we have 4:
Swiftblade
Watly
Naidraug
feyeleanor

Let's get them working on something! I can start monitoring the bugtracker again if needed, although it would help if I could actually change the status, instead of just the resolution.
Title: Re: Coder qualifications
Post by: Tom on August 07, 2013, 03:03:36 PM
I'm moving the newspaper concept to M&F, where it solves me a few other issues as well (realm boards, etc):

http://forum.mightandfealty.com/index.php/topic,590.0.html
Title: Re: Coder qualifications
Post by: Swiftblade on August 07, 2013, 03:41:17 PM
Why don't you find some easyish bugs that need fixing, make an IRC channel for the four of us, and just let us know what its meant to do, yadda yadda, and the four of us can work on it. If we fix it, then you have a bug fixed, and it cost you a little time. If not, you lost a little time and no bug fixed.

However, if out of this experience you put 4 people in, and one comes out as any semblance of a coder, even if its just for fixing bugs, you have doubled the current battlemaster task force.
Title: Re: Coder qualifications
Post by: Anaris on August 07, 2013, 03:44:05 PM
Why don't you find some easyish bugs that need fixing, make an IRC channel for the four of us, and just let us know what its meant to do, yadda yadda, and the four of us can work on it. If we fix it, then you have a bug fixed, and it cost you a little time. If not, you lost a little time and no bug fixed.

However, if out of this experience you put 4 people in, and one comes out as any semblance of a coder, even if its just for fixing bugs, you have doubled the current battlemaster task force.

I second this.

And Swiftblade, there's already an IRC channel for the devs. And since the rest of the dev team has been pretty inactive (for their various reasons) for the past few months, it's not like chatting with the 4 of you would interrupt anything, or like there would be confidential full-devs-only talk going on in there all the time that we'd have to ask you to leave for.
Title: Re: Coder qualifications
Post by: Swiftblade on August 07, 2013, 04:06:07 PM
Well then it could be a great boon to the game, and wouldn't really cost that much in terms of time.

If the bug code was emailed (or some other way we could all have access to it), then we could use the IRC to come together and discuss. If we started with that and built from there, then we could just take the rest as it comes.
Title: Re: Coder qualifications
Post by: Tom on August 07, 2013, 04:42:37 PM
If Tim wants to put in the time, I won't stop him.

Title: Re: Coder qualifications
Post by: Watly on August 07, 2013, 05:11:32 PM
Whatever happens, I am going to learn PHP and doctrine in the meantime. I do wish for you to know that I am underaged in the case of legal and principal issues. I am socially fine around adults, so it shouldn't be that of an issue.

I am also quick to learn: show it to me once and I have it under the belt in a few minutes.

I am really looking forward to this opportunity to returning the favour.
Title: Re: Coder qualifications
Post by: feyeleanor on August 07, 2013, 05:25:28 PM
I've 30 years coding experience and it's my hobby as well as my day job, so getting up to speed on things isn't usually a problem. I can probably commit one evening a week to getting stuff done (about four hours) and whilst that's not a great deal of time it's probably enough to knock off bugs, write tests, clean up crufty code, etc.
Title: Re: Coder qualifications
Post by: Indirik on August 07, 2013, 06:36:21 PM
Try out these demos and then tell me you wouldn't take those any day over fiddling with {{Usr|Tom}}}}|author = {{Usr|Indirik}}}}{{TattleLeft|date = May  21, 2010|title = Server Status.
That's the point of the semantic forms. You define text boxes where the person just puts in their data, and the form handles all the coding. Just like filling out a web form when you buy something online. No more fiddling with markup code for the user.
Title: Re: Coder qualifications
Post by: Foundation on August 07, 2013, 06:41:47 PM
I wouldn't mind helping Tim out with reviewing diffs and stuff occasionally. I don't have much time these days, but this sounds sufficiently fun and with better potential for returns than prior attempts at integrating new devs. :)
Title: Re: Coder qualifications
Post by: Tom on August 08, 2013, 08:24:32 PM
Last post on the newspaper topic (if you want to discuss it, please start a new topic):

(https://dl.dropboxusercontent.com/u/9638874/maf/newspaper-test.png)

One day, as I said. Crazy easy to use. WYSIWYG editor, layout via drag&drop.
Integrated with M&F, but characters are the only link to anything else in the game, so it would be possible to plug it on to BM in the future.

Title: Re: Coder qualifications
Post by: Swiftblade on August 09, 2013, 02:25:22 PM
Nice, we should work on getting that system into BM aswell at some stage, would be pretty chill.
Title: Re: Coder qualifications
Post by: egamma on August 09, 2013, 09:24:54 PM
http://bugs.battlemaster.org/view.php?id=7542 (http://bugs.battlemaster.org/view.php?id=7542)
http://bugs.battlemaster.org/view.php?id=7553 (http://bugs.battlemaster.org/view.php?id=7553)
http://bugs.battlemaster.org/view.php?id=7587 (http://bugs.battlemaster.org/view.php?id=7587)

Okay, these are just database rows that need to be added, but it might make a good "teachable moment".
Title: Re: Coder qualifications
Post by: Tom on August 12, 2013, 09:48:01 AM
http://bugs.battlemaster.org/view.php?id=7542 (http://bugs.battlemaster.org/view.php?id=7542)
http://bugs.battlemaster.org/view.php?id=7553 (http://bugs.battlemaster.org/view.php?id=7553)
http://bugs.battlemaster.org/view.php?id=7587 (http://bugs.battlemaster.org/view.php?id=7587)

Okay, these are just database rows that need to be added, but it might make a good "teachable moment".

Not really, because these are things I need to do manually at the DB. :-)