Combat should take place after rogue spawn and before rogue damage

[Chenier]

It's really annoying whenever these hordes spawn in heavily-fortified regions and do significant damage while the army doesn't engage. Especially if they go on to damage the walls, which are costly to repair and which you'd figure would be where your army is, ready to defend.

[egamma]

Yes, this would be nice.

[Shizzle]

Makes sense

[GoldPanda]

+1

[Anaris]

I don't have the code in front of me, but it's very possible that this is completely impractical to code, due to the way the turn scripts are run.  It might require splitting a turn script or changing script orders, which is basically not going to happen.

[Shizzle]

Reality check

[egamma]

I don't have the code in front of me, but it's very possible that this is completely impractical to code, due to the way the turn scripts are run.  It might require splitting a turn script or changing script orders, which is basically not going to happen.

Can we put this on the Doctrine conversion list as a "nice to have"? Since you're recoding everything anyway...

[De-Legro]

Can we put this on the Doctrine conversion list as a "nice to have"? Since you're recoding everything anyway...

There is a slight differences between refactoring to make use of Doctrine and completely recoding. One of the devs will obviously have a better understanding, but to my knowledge Doctrine is mostly related to the SQL queries and data management, so it doesn't necessitate changing the order things work in.

[Tom]

There is a slight differences between refactoring to make use of Doctrine and completely recoding. One of the devs will obviously have a better understanding, but to my knowledge Doctrine is mostly related to the SQL queries and data management, so it doesn't necessitate changing the order things work in.

Correct. While we do change a few things while we come across them, this is not a total code refactoring.

[Jens Namtrah]

I don't have the code in front of me, but it's very possible that this is completely impractical to code, due to the way the turn scripts are run.  It might require splitting a turn script or changing script orders, which is basically not going to happen.

all turn changes run a series of function calls. reordering the function calls is child's play.

the problem is that each function currently calls too many actions. if you split up the functions into singular "functions", as they should be, it will be much easier to control things like monster spawns, starvation effects, etc.

[Anaris]

all turn changes run a series of function calls. reordering the function calls is child's play.

Sure; just changing the order in which things happen would, indeed, be utterly trivial.

Changing the order in which things happen without things breaking is much trickier.

As you well know.

[fodder]

what's more annoying is the bit where you've destroyed them already. then they go and kill another 10% of your production and go poof

[Jens Namtrah]

Sure; just changing the order in which things happen would, indeed, be utterly trivial.

Changing the order in which things happen without things breaking is much trickier.

As you well know.

exactly.

Which is precisely why what I said in the half of my post you DIDN'T quote is so important.

Fortunately, the whole point behind an ORM is to help with stuff like this, so hopefully when you're finally able to get that refactoring sorted out, it will help make this easier to change.

[Chenier]

what's more annoying is the bit where you've destroyed them already. then they go and kill another 10% of your production and go poof

It is quite annoying how they keep on damaging stuff even when you kicked their asses.

Can you actually hunt dispersed rogues? It never seems to work...

[GoldPanda]

I thought there were plans to add some simple checks to prevent this?

1. Rogue forces cannot loot when hostile troops are present, just like everyone else. Since rogues are at war with everyone, this means that rogues cannot damage a region when other troops are present.

2. Rogue forces cannot loot if they are in the retreated, scattered, or rallying states, again, just like everyone else.

All we're asking for is that rogue forces get the same restrictions as normal troops when it comes to looting, and not treated as special cases.