Main Menu

News:

Please be aware of the Forum Rules of Conduct.

New Editor

Started by Tom, January 11, 2012, 07:59:56 PM

Previous topic - Next topic

Tom

I'm replacing the WYSIWYG editor in BattleMaster with the more advanced CKEditor. It has been in a few remote places for a few weeks already and caused no problems, so I'm now rolling it out to most of the game (on testing, at least).

The new editor has a couple really nice features. But if you notice anything that got lost, let me know.


LilWolf

#1
Is it intentional that it over rides the fact you've set the editor to be used to Plain/HTML in your account options?

Also, this new editor does insane line spacings if you use enter to change lines(which most people will).
Join us on IRC #battlemaster@QuakeNet
Read about the fantasy stories I'm writing.

Indirik

Can it be skinned to blend into the interface? It's really "in your face" right now.
If at first you don't succeed, don't take up skydiving.

^ban^

Quote from: LilWolf on January 11, 2012, 08:13:50 PM
Also, this new editor does insane line spacings if you use enter to change lines(which most people will).

This is a bit of an understatement... it's inserting four lines for every time you press enter.
Born in Day they knew the Light; Rulers, prophets, servants, and warriors.
Life in Night that they walk; Gods, heretics, thieves, and murderers.
The Stefanovics live.

Tom

Quote from: LilWolf on January 11, 2012, 08:13:50 PM
Is it intentional that it over rides the fact you've set the editor to be used to Plain/HTML in your account options?

Also, this new editor does insane line spacings if you use enter to change lines(which most people will).

Hm, that is strange. I'm fairly sure that it isn't due to the editor but the processing we do on the backend.

And yes, the override is intentional. If you don't have javascript enabled, this editor will gracefully degrade to a regular textbox. I don't see any other reasons not to use it.

Quote from: Indirik on January 11, 2012, 08:27:31 PM
Can it be skinned to blend into the interface? It's really "in your face" right now.
Yes, it has very nice skinning options. Want to give it a try? The ckeditor website has documentation on how to create your own skin.

Shizzle

Also, I noticed some ugly things happening when pasting in text?

Tom

several input problems are fixed now. They were due to the old code overzelously cleaning the input. Twice. And then again for good measure. :)

Indirik

One major problem for me, and I assume others as well: The browser's built-in spell checker does not run inside the new editor. I *really* counted on that feature....
If at first you don't succeed, don't take up skydiving.

Zakilevo

yeah. I need put google on all the time!

Tom

It's a matter of config options, as it supports both browser-internal and its own spellchecker. I'll have to read the docs and test some settings.


fodder

i prefer plain text... hate copy/pasting stuff and having it end up with strange font/color, etc in those fancy editors.
firefox

Solari

Quote from: fodder on January 12, 2012, 12:01:43 PM
i prefer plain text... hate copy/pasting stuff and having it end up with strange font/color, etc in those fancy editors.

Paste as plain text.  Any operating system can do this.

Indirik

The editor has a built-in "paste as plain text" option. It's one of the toolbar buttons.
If at first you don't succeed, don't take up skydiving.

Anaris

Quote from: Solari on January 12, 2012, 02:06:51 PM
Paste as plain text.  Any operating system can do this.

Orly?

Perhaps you'd like to educate us all by describing how it is done on every operating system?

Or, if you object to my being overly literal, every current version of a major operating system?
Timothy Collett

"The only thing you can't trade for your heart's desire...is your heart." "You are what you do.  Choose again, and change." "One of these days, someone's gonna plug you, and you're going to die saying, 'What did I say? What did I say?'"  ~ Miles Naismith Vorkosigan

Indirik

Chrome on Windows has a right-click "Paste as plain text" option. However... CKEditor  intercepts that right-click and pops up its own context menu instead, which only has a "
Paste" option. For me, that option then causes CKEditor to complain that my security settings have blocked the editor from accessing the clipboard, and requiring me to paste the text into another pop-up dialog and hit the OK button. Quite the ridiculous process for a simple paste task.

The new editor seems to work OK, but the interface is definitely rough in some spots.
If at first you don't succeed, don't take up skydiving.